Fix MSE calibration distributed amax sync and add multi‑GPU test#730
Open
CedricHwong wants to merge 3 commits intoNVIDIA:mainfrom
Open
Fix MSE calibration distributed amax sync and add multi‑GPU test#730CedricHwong wants to merge 3 commits intoNVIDIA:mainfrom
CedricHwong wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: CedricHwong <997630814@qq.com>
Signed-off-by: CedricHwong <997630814@qq.com>
Signed-off-by: CedricHwong <997630814@qq.com>
356ab95 to
41180e9
Compare
Contributor
|
Can we hold off on this PR. We are currently running into issues related to Megatron MoE max calibration. See #752 In addition, amax calibration across mse is not as straight forward as implemented in this PR. Considering that we are still getting mse calibration results, this feature is too early in my opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
Overview:
Usage
Testing
PYTHONPATH=/root/epfs/workspace/code/personal_repos/Model-Optimizer pytest -q tests/gpu/torch/quantization/test_mse_calibrate_sync.py - Result: 3 passed, 1 skipped (skip: 1‑GPU case)Additional Information